mmap_registers: Made mmap functionality conditional on mmap support#3294
Closed
bgoing-micron-oss wants to merge 1 commit intolinux-nvme:masterfrom
Closed
mmap_registers: Made mmap functionality conditional on mmap support#3294bgoing-micron-oss wants to merge 1 commit intolinux-nvme:masterfrom
bgoing-micron-oss wants to merge 1 commit intolinux-nvme:masterfrom
Conversation
Bypassed the mmap functionality in mmap_registers if the target platform doesn't support mmap. Created munmap_registers for conditional unmap usage as well. Used NVME_HAVE_MMAP to avoid conflict with python's HAVE_MMAP definition when building python wrappers. Signed-off-by: Broc Going <[email protected]>
Collaborator
|
I've updated the commit message so it uses present tense and applied it directly. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bypassed the mmap functionality in mmap_registers if the target platform doesn't support mmap. Created munmap_registers for conditional unmap usage as well.
Used NVME_HAVE_MMAP to avoid conflict with python's HAVE_MMAP definition when building python wrappers.